fix: point to the right doc in formatting#2731
Conversation
The function `CleanValueKubernetes` from the `formatting` package is poiting to the wrong documentation. This change updates the comment only. Signed-off-by: Francesco Ilario <filario@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the CleanValueKubernetes function in pkg/formatting/k8labels.go to correctly reference Kubernetes label value syntax instead of DNS subdomain names. The listed rules for valid label values were also updated for clarity and accuracy. I have no feedback to provide as there were no review comments.
filariow
force-pushed
the
fix-label-value-formatting
branch
from
bbefa2b to
3d024e6
Compare
|
/ok-to-test |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
=======================================
Coverage 59.36% 59.36%
=======================================
Files 208 208
Lines 20626 20626
=======================================
Hits 12244 12244
Misses 7610 7610
Partials 772 772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
![pipelines-as-code[bot]](https://avatars.githubusercontent.com/in/112592?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats @filariow your PR Has been approved 🎉
✅ Pull Request Approved
Approval Status:
- Required Approvals: 1
- Current Approvals: 1
👥 Reviewers Who Approved:
| Reviewer | Permission Level | Approval Status |
|---|---|---|
| @zakisk | write |
✅ |
📝 Next Steps
- Ensure all required checks pass
- Comply with branch protection rules
- Request a maintainer to merge using the
/mergecommand (or merge it
directly if you have repository permission).
Automated by the PAC Boussole 🧭
3 participants
The function
CleanValueKubernetesfrom theformattingpackage is poiting to the wrong documentation.This change updates the comment only.
Signed-off-by: Francesco Ilario filario@redhat.com
📝 Description of the Change
🔗 Linked GitHub Issue
N/A
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.